accel-ppp locking, 200% cpu and fills logs until there's no space left.

PPPoE related questions
zash
Posts: 12
Joined: 03 Apr 2016, 22:17

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by zash »

@ddobrev Sorry for the late response.

I downgraded accel-ppp to 1.10.2 on June 10 on both servers. Kernel remains the same (version 4.4.6 and 4.4.12 on the servers). So far no issues to this day.
ddobrev
Posts: 8
Joined: 04 Jul 2016, 12:44

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by ddobrev »

[2016-07-09 11:54:58]: msg: accel-ppp version 2de5323e832b0eaa3aaea748f60d4d481f0e3e87 (LATEST from git repository)
Kernel 4.4.0-24-generic

Problem still remains - the log goes >2GB, I have to manually kill accel-ppp - it won't stop from the init script.
ddobrev
Posts: 8
Joined: 04 Jul 2016, 12:44

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by ddobrev »

zash wrote:@ddobrev Sorry for the late response.

I downgraded accel-ppp to 1.10.2 on June 10 on both servers. Kernel remains the same (version 4.4.6 and 4.4.12 on the servers). So far no issues to this day.

Can you tell me exact git revision of the release you downgraded to, so I can test ?
zash
Posts: 12
Joined: 03 Apr 2016, 22:17

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by zash »

ddobrev wrote:
zash wrote:@ddobrev Sorry for the late response.

I downgraded accel-ppp to 1.10.2 on June 10 on both servers. Kernel remains the same (version 4.4.6 and 4.4.12 on the servers). So far no issues to this day.

Can you tell me exact git revision of the release you downgraded to, so I can test ?
git clone git://git.code.sf.net/p/accel-ppp/code accel-ppp-code
cd accel-ppp-code
git checkout 1.10.2
hugleo
Posts: 59
Joined: 13 Apr 2016, 14:28

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by hugleo »

ddobrev wrote:[2016-07-09 11:54:58]: msg: accel-ppp version 2de5323e832b0eaa3aaea748f60d4d481f0e3e87 (LATEST from git repository)
Kernel 4.4.0-24-generic

Problem still remains - the log goes >2GB, I have to manually kill accel-ppp - it won't stop from the init script.

Maybe this time the log message is different?
Can you paste here?
stasn77
Posts: 8
Joined: 02 Mar 2016, 15:21

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by stasn77 »

Code: Select all

[2016-07-06 07:31:21]: error: ppp449: ppp_chan_read: short read 0

Code: Select all

--- a/accel-pppd/ppp/ppp.c
+++ b/accel-pppd/ppp/ppp.c
@@ -370,6 +370,9 @@ cont:
                        break;
                }

+               if (ppp->buf_size == 0)
+                       break;
+
                if (ppp->buf_size < 2) {
                        log_ppp_error("ppp_chan_read: short read %i\n", ppp->buf_size);
                        continue;
hugleo
Posts: 59
Joined: 13 Apr 2016, 14:28

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by hugleo »

I think you have applied the patch in the wrong line:
Looking at the git the line modified is before log_ppp_error("ppp_unit_read: short read %i\n", ppp->buf_size) not before log_ppp_error("ppp_chan_read:...

yours:

~ Line 373:

Code: Select all

		if (ppp->buf_size == 0)
			break;

		if (ppp->buf_size < 2) {
			log_ppp_error("ppp_chan_read: short read %i\n", ppp->buf_size);
			continue;
		}
correct:
Line 421:

Code: Select all

		if (ppp->buf_size == 0)
			break;

		if (ppp->buf_size < 2) {
			log_ppp_error("ppp_unit_read: short read %i\n", ppp->buf_size);
			continue;
		}
ddobrev
Posts: 8
Joined: 04 Jul 2016, 12:44

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by ddobrev »

Here is the message from version 2de5323e832b0eaa3aaea748f60d4d481f0e3e87:
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ppp_chan_read: short read 0
[2016-07-10 17:36:59]: error: ppp1: ail: accel-ppp.log: file truncated
[2016-07-10 17:37:05]: msg: accel-ppp version 2de5323e832b0eaa3aaea748f60d4d481f0e3e87
hugleo
Posts: 59
Joined: 13 Apr 2016, 14:28

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by hugleo »

I just figured out now that the stasn77 message was a patch and not reporting a error.
:D

Maybe is safe that you put the line:

if (ppp->buf_size == 0)
break;

before "ppp_chan_read: short read" too?

Dmitry, can you check that patch?
_longhorn_
Posts: 36
Joined: 03 Sep 2015, 14:37

Re: accel-ppp locking, 200% cpu and fills logs until there's no space left.

Post by _longhorn_ »

После обновления больше не падал. Спасибо!
Post Reply