Removal of shaper by COA

Shaper related questions
Post Reply
lbw
Posts: 27
Joined: 09 Mar 2019, 00:16

Removal of shaper by COA

Post by lbw »

Hi

This is as much a note for others as a question. Changing shaper by COA works fine:

[2019-12-22 18:34:35]: info: ppp89: recv [RADIUS CoA-Request id=a0 <Acct-Session-Id "7317a647d925efeb"> <Filter-Id "20000/20000">]
[2019-12-22 18:34:35]: info: ppp89: shaper: changed shaper 20000/20000 (Kbit)
[2019-12-22 18:34:52]: info: ppp89: send [RADIUS CoA-ACK id=a0]

However, removal by setting it to 0/0 doesn't seem to work:

[2019-12-22 18:34:52]: info: ppp89: recv [RADIUS CoA-Request id=a1 <Acct-Session-Id "7317a647d925efeb"> <Filter-Id "0/0">]
[2019-12-22 18:34:52]: info: ppp89: send [RADIUS CoA-ACK id=a1]

I'm expecting to see:

log_ppp_info2("shaper: removed shaper\n");

I also tried Filter-Id: 0 but no good. The shaper isn't removed:

# tc qdisc show dev ppp89
qdisc tbf 1: root refcnt 2 rate 20Mbit burst 250000b lat 50.0ms
qdisc ingress ffff: parent ffff:fff1 ----------------

However, I then tried Filter-Id: -1/-1 and that seems to remove the shaper:

tc qdisc show dev ppp89
qdisc pfifo_fast 0: root refcnt 2 bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1

However, using the CLI, the output is different from something that never had a shaper in the first place:

accel-ppp# show sessions rate-limit match ifname ppp89
rate-limit
------------
-1/-1

accel-ppp# show sessions rate-limit match ifname ppp90
rate-limit
------------

Not sure if that's indicative of any unintended consequences or issues?

Thanks
dimka88
Posts: 866
Joined: 13 Oct 2014, 05:51
Contact:

Re: Removal of shaper by COA

Post by dimka88 »

Hello lbv, can you try patch for fix issue with shaper remove by CoA request?
https://raw.githubusercontent.com/Dmitr ... set_shaper
Post Reply